Re: [TRIVIAL][PATCH]:/proc/fs/nfsd/

From: Neil Brown
Date: Fri Mar 05 2004 - 06:29:51 EST


On Friday March 5, VANDROVE@xxxxxxxxxx wrote:
> On 5 Mar 04 at 21:08, Neil Brown wrote:
> > > The following patch fixes it.
> >
> > Does it need fixing??
> >
> > If you remove this, then people who compile a kernel without nfsd
> > support, and then later decide to compile an nfsd module and load it,
> > will not be able to mount the nfsd filesystem at the right place.
>
> > I think it is a very small cost, and a measurable gain, to leave it
> > there.
>
> Maybe I'm stupid, but why cannot knfsd module create fs/nfsd
> directory at module load? That way you can do insmod/modprobe followed
> by mount() to do that. And if you'll fiddle with do_mount a bit
> (so that get_fs_type() is invoked before walking mount path)
> you can do it even without modprobing knfsd in advance, by just
> doing 'mount none /proc/fs/nfsd -t nfsd'.
> Petr Vandrovec

I wanted
mount -t nfsd nfsd /proc/fs/nfsd
to load the module and, as you have noticed, that doesn't work.

"fiddle"ing with do_mount is an interesting idea. If you (or someone)
can make that work and get it accepted, I am happy to have the nfsd
module create the directory.

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/