Re: [PATCH] For test only: pmac_zilog fixes (cups lockup at boot):

From: Benjamin Herrenschmidt
Date: Fri Mar 05 2004 - 04:07:58 EST


On Fri, 2004-03-05 at 19:58, Russell King wrote:
> On Fri, Mar 05, 2004 at 06:54:31PM +1100, Benjamin Herrenschmidt wrote:
> > Ok, so I finally got a hand on the problems. A mix of bugs in
> > the driver, bugs in the HW, and bugs in the TTY layer ! pfiew.
>
> I'm not even going to bother reviewing these changes - the gratuitous
> change of "up" to "uap" makes this task virtually impossible.

Oh... and the change wasn't gratuitous... "up" do actually conflict
with up() as soon as you try to use a semaphore :)

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/