Re: APM suspend causes uninterruptible sleep

[Pavel Machek]

Hi!

> Between alsa-driver 0.9.4 and alsa-driver 0.9.5 the change below was made.
> Since then, suspending with a program outputting to the pcm device
> causes that program to enter the uninterruptible sleep state. Reverting
> this patch fixes the problem. The problem exists in 0.9.5 through 1.0.2c.
> 
> This problem affects kernel 2.6.3; applying the reversion of this patch
> fixes it.

This should really use driver model...

> 
> diff -urN alsa-driver-0.9.4/alsa-kernel/isa/cs423x/cs4231_lib.c alsa-driver-0.9.5/alsa-kernel/isa/cs423x/cs4231_lib.c
> --- alsa-driver-0.9.4/alsa-kernel/isa/cs423x/cs4231_lib.c	Wed Apr 30 23:53:17 2003
> +++ alsa-driver-0.9.5/alsa-kernel/isa/cs423x/cs4231_lib.c	Tue Jul  8 22:42:09 2003
> @@ -1401,8 +1401,10 @@
> 
>  	switch (rqst) {
>  	case PM_SUSPEND:
> -		if (chip->suspend)
> +		if (chip->suspend) {
> +			snd_pcm_suspend_all(chip->pcm);
>  			(*chip->suspend)(chip);
> +		}
>  		break;
>  	case PM_RESUME:
>  		if (chip->resume)
> 
> -- 
> Just because it isn't nice doesn't make it any less a miracle.
>      http://users.albatross.co.nz/~psycho/     O-   -><-
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/