Re: [BK PATCH] SCSI host num allocation improvement

From: Mike Anderson
Date: Fri Feb 27 2004 - 11:38:38 EST


Ben Collins [bcollins@xxxxxxxxxx] wrote:
> static void scsi_host_cls_release(struct class_device *class_dev)
> {
> + down(&host_num_lock);
> + idr_remove(&allocated_hosts, class_to_shost(class_dev)->host_no);
> + up(&host_num_lock);
> put_device(&class_to_shost(class_dev)->shost_gendev);
> }
>

Should the idr_remove be done in scsi_host_dev_release instead? We
really should not make this number available until everyone is done with
this host.

-andmike
--
Michael Anderson
andmike@xxxxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/