Re: raid 5 with >= 5 members broken on x86

[Linus Torvalds]

On Thu, 26 Feb 2004, Linus Torvalds wrote:
> 
> Btw, the "xor_pII_mmx_5()" thing just uses "+r" for the line count, so why 
> doesn't that work for this case?

In other words, shouldn't this work for all compilers also? I don't see 
why this shouldn't compile if the pII version compiles? 

Yes, it's pushing the register pressure a bit, but it would seem to be
the simplest fix..

		Linus

===== include/asm-i386/xor.h 1.14 vs edited =====
--- 1.14/include/asm-i386/xor.h	Tue Mar 11 18:15:03 2003
+++ edited/include/asm-i386/xor.h	Thu Feb 26 14:03:17 2004
@@ -489,7 +489,7 @@
 	"       jnz 1b               ;\n"
 	"	popl %5\n"
 	"	popl %4\n"
-	: "+g" (lines),
+	: "+r" (lines),
 	  "+r" (p1), "+r" (p2), "+r" (p3)
 	: "r" (p4), "r" (p5)
 	: "memory");
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/