Re: Bug#234754: kernel-source-2.6.3: Badness on Software Suspend

[Herbert Xu]

tags 234754 pending
quit

On Wed, Feb 25, 2004 at 05:45:20PM +0100, Roland Stigge wrote:
> Package: kernel-source-2.6.3
> Version: 2.6.3-2
> Severity: normal
> 
> on Software Suspend (echo 4 >/proc/acpi/sleep), I get Badness messages
> written to my screen (and syslog). I attached the syslog excerpt and the
> boot messages.

> Feb 25 17:29:26 bird kernel: Fixing swap signatures... ok
> Feb 25 17:29:26 bird kernel: Badness in redraw_screen at drivers/char/vt.c:607
> Feb 25 17:29:26 bird kernel: Call Trace:
> Feb 25 17:29:26 bird kernel:  [redraw_screen+496/501] redraw_screen+0x1f0/0x1f5
> Feb 25 17:29:26 bird kernel:  [do_magic_resume_2+209/246] do_magic_resume_2+0xd1/0xf6

This patch should shut it up.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Index: kernel-2.5/kernel/power/swsusp.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/kernel/power/swsusp.c,v
retrieving revision 1.1.1.6
diff -u -r1.1.1.6 swsusp.c
--- kernel-2.5/kernel/power/swsusp.c	19 Feb 2004 08:56:02 -0000	1.1.1.6
+++ kernel-2.5/kernel/power/swsusp.c	26 Feb 2004 10:26:21 -0000
@@ -619,7 +619,9 @@
 	PRINTK( "ok\n" );
 
 #ifdef SUSPEND_CONSOLE
+	acquire_console_sem();
 	update_screen(fg_console);	/* Hmm, is this the problem? */
+	release_console_sem();
 #endif
 }