Re: Double fb_console_init call during do_initcalls

From: James Simmons
Date: Fri Feb 20 2004 - 14:58:06 EST



> Ugh. fb_console_init() can be called by
> drivers/char/vt.c (one initcall) or drivers/video/fbmem.c or
> drivers/video/console/fbcon.c (<-- module_init/initcall).
>
> It definitely wants to be cleaned up, but changing initcall
> order can be "fragile". Have you tried/tested it?
>
> Or maybe James Simmons has some updates for this.

I seen the report and begain to create a patch. The module_init fix is
easy. Just place module_init and module_exit under #ifdef MODULE. I
realize alot of fbdev drivers do this wrong. I will make patches by the
end of the day. As for the fbmem.c call on fb_console_init. Well that is
tricker to deal with. I will have to figure out a way.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/