Re: [BK PATCH] USB update for 2.6.3

From: Linus Torvalds
Date: Fri Feb 20 2004 - 01:27:54 EST




On Fri, 20 Feb 2004, Benjamin Herrenschmidt wrote:
>
> A while ago, I've advertised making this API a set of function
> pointers attached to the struct device inherited from the bus
> parent, so the core code just set one for the root PCIs and
> everybody inherits them.... But of course, since x86 isn't
> affected, nobody cared ;)

Well, in all fairness, that _is_ what "platform_data" is supposed to be. A
platform-specific pointer to whatever data structure that platform needs
to have to do the device ops. Platforms that don't need the function
pointers wouldn't have any function pointers there, while others would
have not just the function pointers, but could have some other
bus-dependent data too.

(And this is what at least HP-PA does, as does ARM...)

So it's definitely not unsuitable for this. It does seem like USB jumped
the gun a bit, though.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/