Re: Intel x86-64 support patch breaks amd64

From: Andi Kleen
Date: Thu Feb 19 2004 - 14:42:06 EST


On Thu, 19 Feb 2004 14:36:10 -0500
Jakub Jelinek <jakub@xxxxxxxxxx> wrote:

> On Fri, Feb 20, 2004 at 05:13:37PM +0100, Andi Kleen wrote:
> > --- linux-2.6.3/arch/x86_64/kernel/x8664_ksyms.c-o 2004-02-19 09:01:09.000000000 +0100
> > +++ linux-2.6.3/arch/x86_64/kernel/x8664_ksyms.c 2004-02-19 09:08:04.000000000 +0100
> > @@ -194,7 +194,9 @@
> >
> > EXPORT_SYMBOL(die_chain);
> >
> > +#ifdef CONFIG_SMP_
>
> ^ Isn't this a typo?

Indeed. Thanks for catching it.

It probably doesn't hurt because I don't know of any module that uses cpu_sibling_map[].
I think I just copied the export from i386. Maybe it would be best to just remove it completely.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/