Re: [PATCH 2.6.3-rc2-mm1] address_space_serialize_writeback patch

From: Andrew Morton
Date: Tue Feb 17 2004 - 20:47:56 EST


Daniel McNeil <daniel@xxxxxxxx> wrote:
>
> Here is the patch that does what you suggested. It adds a rwsema to
> the address_space and do_writepages() uses it serialize writebacks.

Did you verify that we actually _need_ the semaphore? I seem to recall that
it was a "try this, otherwise add the semaphore" thing. Where "this" was "always
remark the page dirty".

Probably we do need the semaphore, but I'd just like to check that you checked ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/