Re: Linux 2.6.3-rc3

[Geert Uytterhoeven]

On Sun, 15 Feb 2004, Peter Osterlund wrote:
> Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> writes:
> > BTW. This is the reason I left the "old" driver in, you can still
> > build it if the new ones goes wrong.
>
> Yes, you can still build the old driver, but it doesn't work unless
> you also apply this patch:
>
> --- linux/drivers/video/fbmem.c.old	2004-02-15 11:47:26.000000000 +0100
> +++ linux/drivers/video/fbmem.c	2004-02-15 11:43:42.000000000 +0100
> @@ -222,6 +222,9 @@
>  #ifdef CONFIG_FB_RADEON
>  	{ "radeonfb", radeonfb_init, radeonfb_setup },
>  #endif
> +#ifdef CONFIG_FB_RADEON_OLD
> +	{ "radeonfb_old", radeonfb_init, radeonfb_setup },
> +#endif
>  #ifdef CONFIG_FB_CONTROL
>  	{ "controlfb", control_init, control_setup },
>  #endif

IMHO you'd better keep one single entry for radeonfb and use

    #if defined(CONFIG_FB_RADEON) || defined(CONFIG_FB_RADEON_OLD)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/