[PATCH]: Sparc no longer Fucked Up

From: Rusty Russell
Date: Sun Feb 15 2004 - 02:05:53 EST


From: Keith M Wesolowski <wesolows@xxxxxxxxxxxx>

As of 2.6.3, restore_flags will no longer modify cwp on sparc.
Therefore you can apply this patch to the locking guide.

[ Indeed. I'll also remove the atomic comments from Hacking
Guide as part of my revision there when I get back to it. --RR ]

diff -Nru a/Documentation/DocBook/kernel-locking.tmpl b/Documentation/DocBook/kernel-locking.tmpl
--- a/Documentation/DocBook/kernel-locking.tmpl Sun Feb 8 15:07:26 2004
+++ b/Documentation/DocBook/kernel-locking.tmpl Sun Feb 8 15:07:26 2004
@@ -1444,27 +1444,6 @@
</para>
</sect1>

- <sect1 id="sparc">
- <title>The Fucked Up Sparc</title>
-
- <para>
- Alan Cox says <quote>the irq disable/enable is in the register
- window on a sparc</quote>. Andi Kleen says <quote>when you do
- restore_flags in a different function you mess up all the
- register windows</quote>.
- </para>
-
- <para>
- So never pass the flags word set by
- <function>spin_lock_irqsave()</function> and brethren to another
- function (unless it's declared <type>inline</type>). Usually no-one
- does this, but now you've been warned. Dave Miller can never do
- anything in a straightforward manner (I can say that, because I have
- pictures of him and a certain PowerPC maintainer in a compromising
- position).
- </para>
- </sect1>
-
</chapter>

<chapter id="Efficiency">

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/