Re: [PATCH] back out fbdev sysfs support

[Linus Torvalds]

On Sat, 14 Feb 2004, Christoph Hellwig wrote:
> 
> <rant>
> James, what about pushing the 2GB worth of fbdev driver fixes in your
> tree to Linus so people actually get working fb support again instead
> of adding new holes?

Sorry, but at this point I WOULD NOT EVEN TAKE IT ANY MORE.

That's just how I work: if somebody maintains his own tree and builds up a 
lot of patches, that's _his_ problem. I'm not going to replace things 
totally unless there is some really fundamental reason I would have to. 
And quite frankly, the most common "fundamental reason" is that the 
maintainer has not done his job.

I want controlled patches that do one thing at a time. Not a 2GB untested 
dump.

>  A maintainers job can't be to apply patches to
> his personal CVS repository and sitting on them forever
> </rant>

.. and once he has patches, he can't just "dump" them out, either.

These things need to be done in a timely fashion, incrementally, one thing 
at a time. Anything else does not work.

And btw, for anybody who is impacted by this: you are encouraged to help. 
If you have a machine that works with some out-of-tree code but does 
_not_ work with the in-tree code, send a patch that fixes JUST THAT BUG.

Because if James can't trickle them in, somebody else will have to. That's 
what happened with the new radeon driver.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/