Re: PPC64 PowerMac G5 support available

From: Linus Torvalds
Date: Thu Feb 12 2004 - 10:59:11 EST




On Thu, 12 Feb 2004, Benjamin Herrenschmidt wrote:
>
> Finally, ieee1394 triggers an oops in kobject since 2.6.3-rc2, 100%
> reproduceable for me (and apparently x86 users too), so that's also
> unrelated to the G5 code.

Does the appended fix it?

Linus

---
===== drivers/base/bus.c 1.52 vs edited =====
--- 1.52/drivers/base/bus.c Tue Sep 30 08:59:35 2003
+++ edited/drivers/base/bus.c Thu Feb 12 07:40:44 2004
@@ -158,17 +158,18 @@
int bus_for_each_dev(struct bus_type * bus, struct device * start,
void * data, int (*fn)(struct device *, void *))
{
- struct list_head * head, * entry;
+ struct device *dev;
+ struct list_head * head;
int error = 0;

if (!(bus = get_bus(bus)))
return -EINVAL;

- head = start ? &start->bus_list : &bus->devices.list;
+ head = &bus->devices.list;
+ dev = start ? : to_dev(head);

down_read(&bus->subsys.rwsem);
- list_for_each(entry,head) {
- struct device * dev = get_device(to_dev(entry));
+ list_for_each_entry_continue(dev, head, node) {
error = fn(dev,data);
put_device(dev);
if (error)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/