Re: [PATCH] make __ide_dma_off() generic and remove ide_hwif_t->ide_dma_off

[Bartlomiej Zolnierkiewicz]

On Wednesday 11 of February 2004 13:19, Andre Hedrick wrote:
> Bartlomiej,
>
> __ide_dma_count
>
> This is for VDMA, PIO over DMA.

This *supposes* to be for VDMA, but since its introduction in kernel 2.5.35
(released on 15-Sep-2002!) it does *nothing*.

> When the transport moves to only MMIO, PIO operations are tunneled.
> Just a little hit.
>
> Andre Hedrick
> LAD Storage Consulting Group
>
> On Mon, 9 Feb 2004, Bartlomiej Zolnierkiewicz wrote:
> > Incremental to "[PATCH] remove __ide_dma_count() and
> > ide_hwif_t->ide_dma_count".
> >
> > Move ide-dma.c:__ide_dma_off() outside of #ifdef
> > CONFIG_BLK_DEV_IDEDMA_PCI, so it can be used for all DMA capable hosts. 
> > Remove ide_hwif_t->ide_dma_off.

>From the previous mail:

[PATCH] remove __ide_dma_count() and ide_hwif_t->ide_dma_count

Incremental to "[PATCH] remove ide_dma_{good,bad}_drive from ide_hwif_t".

->ide_dma_count() was introduced in kernel 2.5.35 and was meant to add support
for host FIFO counters (for VDMA), but is only a wrapper for ->ide_dma_begin()
(even for siimage.c b/c SIIMAGE_VIRTUAL_DMAPIO is undefined).

Moreover it should be possible to add VDMA code directly to ->ide_dma_begin().

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/