Re: [TRIVIAL patch] 2.6.2-rc2 Remove compile warnings from timer.o

[Darren Williams]

On Tue, 10 Feb 2004, Andrew Morton wrote:

> You should lose the ifdefs.  Just do:
> 
> 	if (SHIFT_SCALE <= (SHIFT_USEC + SHIFT_HZ)) {
> 		if (ltemp < 0)
> 			time_adj -= -ltemp >>
> 				(SHIFT_USEC + SHIFT_HZ - SHIFT_SCALE);
> 		else
> 			time_adj += ltemp >>
> 				(SHIFT_USEC + SHIFT_HZ - SHIFT_SCALE);
> 	}
> 	...
> 
> because
> 
> a) It is not revolting and
> 
> b) The compiler checks the unused code for you, then throws it away.
> 
However this does not remove the compile warnings.

Darren

--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/