RE: 2.4.25-rc1: Inconsistent ioctl symbol usage in drivers/messag e/fusion/mptctl.c

From: Mikael Pettersson
Date: Tue Feb 10 2004 - 11:27:39 EST


Moore, Eric Dean writes:
> If we pass NULL as the 2nd parameter for register_ioctl32_conversion(),
> the mpt_ioctl() entry point is *not* called when running a 32 bit
> application in x86_64 mode.

Ok, but you still don't need sys_ioctl() since the one-liner

> > filp->f_op->ioctl(filp->f_dentry->d_inode, filp, cmd, arg)

(or a hardcoded call to your ioctl() method) suffices.

sys_ioctl() mostly just checks for special case ioctls before
doing the line above, but those special cases can't occur
since the kernel has already matched your particular ioctl.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/