Re: dmapool (was: Re: Linux 2.6.3-rc2)

From: Russell King
Date: Tue Feb 10 2004 - 09:51:47 EST


On Tue, Feb 10, 2004 at 03:32:47PM +0100, Geert Uytterhoeven wrote:
> On Tue, 10 Feb 2004, Geert Uytterhoeven wrote:
> > The dmapool code makes dma_{alloc,free}_coherent() a requirement for all
> > platforms, breaking platforms that don't have it (e.g. m68k, and from a quick
> > browse sparc and sparc64 probably, too).
> >
> > May not be that nice for a release candidate in a stable series...
>
> This patch seems to fix the problem (all offending platforms include
> <asm/generic.h> if CONFIG_PCI only):

Please don't - that breaks ARM. Part of the whole point of dmapool is
that it provides a generic DMA pool implementation, especially for
non-PCI USB devices.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/