Re: [2.6 PATCH] persist qconf options

[Andreas Fester]

Hi Roman,

thanks for the feedback :-)

> > @@ -1145,6 +1162,10 @@
> >  	menuList->updateListAll();
> >  }
> >
> > +bool ConfigMainWindow::getShowAll() {
> > +	return configList->showAll;
> > +}
> > +
> >  void ConfigMainWindow::setShowDebug(bool b)
> >  {
> >  	if (showDebug == b)
>
>
> All these access functions are really not neccessary.

Well, I think in the sense of an Object Oriented interface
with getter/setter methods they probably *do* make sense ...

> If we change this I'd like to see this done properly. First all the
> settings business should be moved into a small helper class, so that there

Agreed. I thought about something similar, but simply started to
hack some code last night ;-)

> are not x number of new arguments to the ConfigList constructor. The

Agreed. The four additional arguments is what I mostly dislike with my
solution.

> saving of the settings should be connected to aboutToQuit().

Ok.

> Bonus points if you also save the list mode and the position of the
> splitter. :)

Lets see if I can win them :-)

Thanks,

	Andreas

--
Andreas Fester
mailto:Andreas.Fester@xxxxxx
WWW: http://littletux.homelinux.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/