Re: [PATCH] Selective attach for ide-scsi

[Willem Riede]

On 2004.02.09 03:24, Mikael Pettersson wrote:
> Willem Riede writes:
>  > Today, if you boot 2.6.x with hdd=ide-scsi, ide-scsi will attach to
>  > all your Atapi drives, not just hdd, unless you explicitely specified
>  > another driver for those.
>  > 
>  > Given that we don't want people to use ide-scsi for cdroms and cd-writers,
>  > that behavior is IMHO suboptimal.
>  > 
>  > The patch below makes ide-scsi attach ONLY to those drives that you tell
>  > it to. So if you want it to handle hdb and hdd, but not hdc, you boot
>  > with hdb=ide-scsi hdd=ide-scsi.
> 
> The patch I posted, which you apparently didn't like, doesn't
> require the use of boot-only options: it instead adds a module_param
> to ide-scsi which allows for greater flexibility.
> 
> Personally I never liked that butt-ugly hdX=ide-scsi hack.

I hear you. There are certainly advantages to use a module parameter rather
than a boot argument.

However, there should not be two mechanisms to achieve the same goal. For
better or for worse, the hdX=<driver> construction exists, and people are
using it. Its use is not limited to ide-scsi.

Since it can very easily be adjusted to achieve the desired selectivety,
I believe it is the mechanism of choice. 

Does anyone else have an opinion?

Thanks, Willem Riede.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/