Re: [Bug 2013] New: Oops from create_dir (sysfs)

[Greg KH]

On Wed, Feb 04, 2004 at 03:43:42PM -0600, John Rose wrote:
> <crickets chirp>.  That's one way to shut me up :)

Honestly, I like the way this currently works.  You tried to do
something not allowed, and the kernel dies.  Now it would be nice to be
able to provide a better type of error message to help the unsuspecting
developer out, but that's just fluff :)

> In all seriousness, how much of a performance problem would be posed by
> throwing a kset_find_obj() check somewhere in the beginning of
> kobject_add()? 

Why not just fix the sysfs create_dir() function to not oops and report
back the proper error message in this case?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/