Re: [Compile Regression in 2.4.25-pre8][PATCH 15/42]

[Kronos]

Il Wed, Feb 04, 2004 at 02:46:01PM -0200, Marcelo Tosatti ha scritto: 
> > ../fdomain.c:565: warning: `fdomain_setup' defined but not used
> >
> > fdomain_setup isn't used when the driver is modular.
> >
> > diff -Nru -X dontdiff linux-2.4-vanilla/drivers/scsi/fdomain.c linux-2.4/drivers/scsi/fdomain.c
> > --- linux-2.4-vanilla/drivers/scsi/fdomain.c	Sat Jan 31 15:54:42 2004
> > +++ linux-2.4/drivers/scsi/fdomain.c	Sat Jan 31 17:21:13 2004
> > @@ -561,6 +561,7 @@
> >     printk( "\n" );
> >  }
> >
> > +#ifndef MODULE
> >  static int __init fdomain_setup( char *str )
> >  {
> >  	int ints[4];
> > @@ -584,6 +585,7 @@
> >  }
> >
> >  __setup("fdomain=", fdomain_setup);
> > +#endif
> >
> >
> >  static void do_pause( unsigned amount )	/* Pause for amount*10 milliseconds */
> 
> What?
> 
> from fdomain.c:
> 
> #ifdef MODULE
>         if (fdomain)
>                 fdomain_setup(fdomain);
> #endif

Sorry, I misread the #ifdef. Drop the patch.

Luca
-- 
Reply-To: kronos@xxxxxxxxxxxxxx
Home: http://kronoz.cjb.net
"La mia teoria scientifica preferita e` quella secondo la quale gli 
 anelli di Saturno sarebbero interamente composti dai bagagli andati 
 persi nei viaggi aerei." -- Mark Russel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/