Re: bttv oops

From: Greg KH
Date: Tue Feb 03 2004 - 20:07:35 EST


On Mon, Feb 02, 2004 at 04:47:14PM +0100, Gerd Knorr wrote:
> Stephen Clark <stephen.clark@xxxxxxxxxxxxx> writes:
>
> > Gentle people,
> >
> > I am having the following problem. Also if I compile bttv into the
> > kernel I get a panic in the driver at boot.
> >
> > Any ideas?
>
> disable CONFIG_I2C_*_DEBUG, the debug printk() dereference pointers
> unchecked.

Here's the patch that has been reported to fix this oops. I've added it
to my i2c bk tree.

thanks,

greg k-h

# I2C: fix oops when CONFIG_I2C_DEBUG_CORE is enabled and the bttv driver is loaded.

diff -Nru a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
--- a/drivers/i2c/i2c-core.c Tue Feb 3 17:00:46 2004
+++ b/drivers/i2c/i2c-core.c Tue Feb 3 17:00:46 2004
@@ -598,7 +598,7 @@
ret = adap->algo->master_xfer(adap,&msg,1);
up(&adap->bus_lock);

- dev_dbg(&client->dev, "master_recv: return:%d (count:%d, addr:0x%02x)\n",
+ dev_dbg(&client->adapter->dev, "master_recv: return:%d (count:%d, addr:0x%02x)\n",
ret, count, client->addr);

/* if everything went ok (i.e. 1 msg transmitted), return #bytes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/