Re: [PATCH] es1371.c - 8 bit stereo (kernel version 2.4.24)

[Bob Nelson]

NOTE: This is a copy of original e-mail response sent inadvertently
      to only Thomas Sailer. This corrects that oversight by sending
      it along to the linux-kernel mailing list.

On Tue Feb  3 07:34:44 2004 Thomas Sailer wrote the following:

> On Tue, 2004-02-03 at 01:57, Bob Nelson wrote:
>
> > Although the code in the ``es1371.c'' source is not lavishly commented,
>
> That's because the hardware itself is not very well documented. I'm
> having serious trouble understanding what the P2_ENDINC bits should do.

Duly noted, Tom...and thanks for the speedy response to the suggested
patch.

> > it appears that the intent of the author is to use 1 as the operand
> > of the shift for 8-bit audio. However, the original code does not take
> > into account ``SCTRL_P2SMB'', 8-bit stereo. The patch results in 1 being
> > used as the operand for any 8-bit audio file, stereo or mono.
>
> Have you also tried 16bit mono and stereo with your patch? does that
> still work?

Indeed I have -- as you might guess -- the vast majority of the audio is
16-bit and I had to be very careful to verify that the patch for a
``corner condition'' of the unusual 8-bit stereo file didn't break the
normal condition.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/