Re: [PATCH] PC300 update

[Greg KH]

On Wed, Jan 28, 2004 at 05:42:11PM -0200, Marcelo Tosatti wrote:
> 
> - Mark pci_device_id list with __devinitdata

Noooo!!!   I think we've finally audited all uses of this.  Do not do
this please, it is wrong for 2.6.

> - Add #ifdef DEBUG around debug printk()

What's wrong with dev_dbg()?  It gives you a much better idea of which
device is spitting out the messages.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/