Re: [PATCH][2.6] PCI Scan all functions

From: Ivan Kokshaysky
Date: Wed Jan 28 2004 - 16:01:02 EST


On Tue, Jan 27, 2004 at 01:44:44PM -0800, Greg KH wrote:
> > - if (base && base <= limit) {
> > + if (base <= limit) {

I think the patch is safe. Architectures that don't accept
bridge windows (and regular BARs) at bus address 0 already have
that check elsewhere.
For example, in arch/i386/pci/i386.c:pcibios_allocate_bus_resources():
...
for (idx = PCI_BRIDGE_RESOURCES; idx < PCI_NUM_RESOURCES; idx++) {
r = &dev->resource[idx];
if (!r->start)
^^^^^^^^^
continue;
...

Ivan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/