Re: [PATCH] kgdb-x86_64-support.patch for 2.6.2-rc1-mm3

[George Anzinger]

Jim Houston wrote:
> On Tue, 2004-01-27 at 13:02, Andi Kleen wrote:
>
> > On 27 Jan 2004 12:43:20 -0500
> > Jim Houston <jim.houston@xxxxxxxxxxx> wrote:
>
>
> > > arch/x86_64/Kconfig
> > > arch/x86_64/Kconfig.kgdb
> > > 	We used a different approach to selecting DEBUG_INFO.
> > > 	I was not really happy with the way select DEBUG_INFO worked.
> >
> > You reverted it back? 
> >
> > What I did was to change all not really kgdb specific CONFIG_KGDB uses in
> > the main kernel with CONFIG_DEBUG_INFO (mostly CFI support). I don't feel
> > strongly about it, but this way there is no reference to an unknown
> > config symbol in mainline. Also DEBUG_INFO including CFI makes sense I think.

If we are going to use DEBUG_INFO could we change the "-g" it produces to 
"-gdwarft-2", especially since you (and I) are using dwarft2 CFI stuff.

-g
> Hi Andi,
>
> I'm using CONFIG_DEBUG_INFO, but I used a different mechanism to
> select it when KGDB is selected.  I'm still learning to speak Kconfig.
>
> My patch:
>
>    config KGDB
>         bool "Include kgdb kernel debugger"
>         depends on DEBUG_KERNEL
>         select DEBUG_INFO
>         help
>           If you say Y here, the system will be compiled with the debug
>
> Your patch:
>
>   config DEBUG_INFO
>         bool "Compile kernel with debug information" if !KGDB
>         default y
>
> Using "select DEBUG_INFO" selects the option and makes the input box
> on xconfig disappear.  The line describing the option remains, perhaps
> leaving a user wondering why this line doesn't have an input box.
>
> With your version, the DEBUG_INFO option disappears when KGDB forces
> it on.
>
> I was looking for a way to get the old behavior where the 
> the effect was controlled by an OR of the two options.
>
> Jim Houston - Concurrent Computer Corp.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
George Anzinger   george@xxxxxxxxxx
High-res-timers:  http://sourceforge.net/projects/high-res-timers/
Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/