Re: [patch] efivars update for 2.6.1

From: Andrew Morton
Date: Tue Jan 13 2004 - 22:11:48 EST


Matt Tolentino <metolent@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Andrew, David:
>
> Here's a patch that has been posted here before, but not yet
> merged.

Big, isn't it?

> Essentially, it converts efivars (i.e. Matt Domsch's
> driver that provides access to the EFI variable runtime
> services) to export variable information and systab info via
> sysfs.

I'd need confirmation from David M-T and if poss a quick review from Greg K-H.

>From a super-quick scan:

- Someone seems to have mangled the files with an editor which doesn't
understand hard tabs.

- This function:

> +static void __exit
> +efivars_exit(void)
> +{
> + struct list_head *pos, *n;
> +
> + spin_lock(&efivars_lock);
> +
> + list_for_each_safe(pos, n, &efivar_list)
> + efivar_unregister(get_efivar_entry(pos));
> +
> + spin_unlock(&efivars_lock);
> +
> + subsystem_unregister(&vars_subsys);
> + firmware_unregister(&efi_subsys);
> +}

cannot call efivar_unregister() under spinlock - it does all sorts of
illegal-under-spinlock things.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/