Re: [PATCH] drivers/scsi/advansys.c check_region() fix

[Rusty Russell]

In message <20031230134433.GA22187@xxxxxxxxxxxxxx> you write:
> Another trivial check_region() fix verified by Gene

And almost certainly wrong.

The *point* of request_region() is that you do it before any I/O to
the region.

So you can't release it before calling AscGetChipVersion().

Converting this driver is quite a bit of work, since you have to trace
down every path which uses the region and make sure it's covered.  The
fact that it's formatted like an angry haiku doesn't help.

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/