Re: Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested

From: Oleg Drokin
Date: Wed Jan 07 2004 - 05:06:59 EST


Hello!

On Wed, Jan 07, 2004 at 12:26:09PM +0300, Hans Reiser wrote:
> >As for why gcc is finding this, but scripts (e.g. smatch) do not is because
> >scripts generally know nothing about variable types, so they cannot tell
> >this comparison was always false (and since gcc can do this for long time
> >already, there is no point in implementing it in scripts anyway).
> can we get gcc to issue us a warning? there might be other stuff
> lurking around also....

If you add -W switch to CFLAGS, you'd get A LOT of more warnings.
Also just reading manpage on gcc around description of that flag will
give you a list of options to individually turn on certain check types.
Also gcc 3.3 have this sort of " unsigned < 0 | unsigned > 0" checks on by
default, I think.

Bye,
Oleg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/