Re: floppy driver and multiple floppies (was Re: 2.6.0 under vmware ?)

[Rusty Russell]

In message <20040105171431.GA1776@xxxxxxxxxxxxxxx> you write:
> -MODULE_PARM(floppy,"s");
> -MODULE_PARM(FLOPPY_IRQ,"i");
> -MODULE_PARM(FLOPPY_DMA,"i");
> +module_param(floppy, charp, 0);
> +module_param(FLOPPY_IRQ, int, 0);
> +module_param(FLOPPY_DMA, int, 0);

You really don't want these to be visible through sysfs?  I'd expect
0444 rather than 0 as the last arg...

Also it'd be nice to do furthur cleanups and get rid of the #ifdef
MODULE altogether...

Cheers,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/