Re: [PATCH] fix get_jiffies_64 to work on voyager
From: Paulo Marques
Date: Tue Jan 06 2004 - 14:06:39 EST
Linus Torvalds wrote:
On Tue, 6 Jan 2004, Paulo Marques wrote:
....
Yes, we used to do things like that at some point (and your code is
buggy: by leaving out the size, the "volatile" cast casts to the implicit
"int" size in C).
Ugh, stupid mistake. Just wrote the code to fast... :(
Anyway, thanks for your clarification. People like me that code a lot of
user-space stuff, take a while to realize all the implications of SMP, ordering,
preemption, etc., etc.
By the way, after double checking your logic, it looks good as long as there are
no interrupts that take more than 3 jiffies to complete :)
--
Paulo Marques - www.grupopie.com
"In a world without walls and fences who needs windows and gates?"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/