Re: [PATCH] fix get_jiffies_64 to work on voyager

From: Andrew Morton
Date: Tue Jan 06 2004 - 12:07:33 EST


James Bottomley <James.Bottomley@xxxxxxxxxxxx> wrote:
>
> On Tue, 2004-01-06 at 10:19, Andrew Morton wrote:
> > Hm, OK. I hit the same deadlock when running with the "don't require TSCs
> > to be synchronised in sched_clock()" patch from -mm. The fix for that is
> > below. I shall accelerate it.
>
> Actually, I think we need to know why this is happening, since the use
> of these sequence locks is growing.

That would be nice. Can you get a backtrace?

> On voyager I just put it down to HZ
> == 1000 being a bit much for my old pentium 66MHz processors, but if
> you've seen it on a much faster processor, that would tend to indicate
> there's some other problem at work here.

No, it was much simpler in my case: log_buf_len_setup() was accidentally
enabling interrupts early in boot and we were taking a timer interrupt
while holding a write lock on xtime_lock. sched_clock() was requiring a
read lock and boom.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/