Re: [usb-storage] Re: usb-storage && iRIVER flash player problem

From: Alan Stern
Date: Tue Jan 06 2004 - 10:39:10 EST


On Mon, 5 Jan 2004, Matthew Dharm wrote:

> On Mon, Jan 05, 2004 at 09:03:33PM +0100, Javier Marcet wrote:
> > * Matthew Dharm <mdharm-kernel@xxxxxxxxxxxxxxxxxx> [040105 20:02]:
> >
> > >It looks like your device is choking over the ALLOW_MEDIUM_REMOVAL command
> > >-- I've never seen a device broken in this particular way before.
> >
> > >If you edit drivers/scsi/sd.c to remove the sending of that command (it's
> > >normally used to lock the media-eject button on devices that support it),
> > >we should be able to test this theory. If this is the case, then we may
> > >need to modify the SCSI layer to only send that command if the RMB bit is
> > >set.

> Hrm... what's the easiest way for Javier to figure out if his device sets
> the RMB or not?
>
> I feel another SCSI enhancement coming on....

It's not so simple, unfortunately. In 2.6, sd.c already does check that
sdev->removable is set before issuing PREVENT ALLOW MEDIUM REMOVAL.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/