Re: [PATCH]: Fw: [Bugme-new] [Bug 1242] New: devfs oops with SMPkernel (not in UP mode)

[Andrew Morton]

Andrey Borzenkov <arvidjaar@xxxxxxx> wrote:
>
> On Tuesday 16 September 2003 08:27, Andrew Morton wrote:
>  > Andrey,
>  >
>  > didn't we fix this?
>  >
>  >
> 
>  Sorry for delay. Oops is due to concurrent d_instantiate on the same dentry; 
>  the bug was unfortunately quite ugly to fix inside devfs itself.

Andrey, thanks for working on this.  It is good to have a go-to guy for
devfs problems.  They all seem to be nasty nowadays.

>  The attached patch makes sure d_revalidate is always called under parent i_sem 
>  allowing it to drop and reacquire semaphore before going to wait. It provides 
>  both mutual exclusion with devfs_lookup and between d_revalidate, fixing

Alas, people will have a heart-attack over the fs/namei.c changes.  Is it
not possible to add an additional semaphore into devfs to provide this
exclusion?  Are there any alternatives you can think of?



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/