Re: [Dri-devel] 2.6 kernel change in nopage

From: Arjan van de Ven
Date: Thu Jan 01 2004 - 07:12:01 EST


On Thu, 2004-01-01 at 13:03, Michel DÃnzer wrote:

> How does this patch look?

ugly.

I find using #defines for function arguments ugly beyond belief and
makes it really hard to look through code. I 10x rather have an ifdef in
the function prototype (which then for the mainstream kernel drm can be
removed for non-matching versions) than such obfuscation.

Attachment: signature.asc
Description: This is a digitally signed message part