Re: [PATCH] pci_set_dac helper

[David S. Miller]

On Wed, 31 Dec 2003 11:12:42 -0500
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> It seems to me like a lot of drivers wind up getting their 
> pci_set_dma_mask stuff wrong, occasionally in subtle ways.  So, I 
> created a "give me 64-bit PCI DMA" helper function.
> 
> The attached patch demonstrates its use in tg3, from which the logic 
> originated.  It also fixes a tiny bug in tg3, whereby it might return 
> zero on error (rather than -EFOO) if the pci_set_dma_mask succeeds but 
> pci_set_consistent_dma_mask fails.

I'm fine with the helper.

The tg3 error return bug you noticed is already fixed in the tg3
updates I'm sending to Linus today.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/