Re: [PATCH] adaptec 1210sa

[Jeff Garzik]

Justin T. Gibbs wrote:
> > > the idea suggested by Justin was to clear bits 6 and 7 at 0x8a of pci 
> > > configuration space. (which I hope did fine :)
> > >
> > > Thanks Justin :)
> >
> >
> > Does the aar1210 have a different PCI id?  That would make it easy to
> > distinguish, and thus easy to selectively apply your patch only to Adaptec
> > chipsets that need it.
>
>
> The change is harmless for controllers using non-adaptec BIOSes.  You'll
> find that on these other controllers, the interrupt masks are already
> clear.  If this wasn't the case, the current Linux driver wouldn't work
> even on stock boards.


The current Linux driver (well, my sata_sil at least) doesn't work for 
several situations, at the moment :)  I need to handle the watchdog 
timer, and also need to mask a bunch of SATA-phy-specific interrupts.

Now that I see in the docs that these bits are present in the stock 
3112, it makes sense to unconditionally ensure they are clear, thus 
completely eliminating the BIOS from the equation.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/