Re: [PATCH] drivers/cdrom/sjcd.c check_region() fix

[Gene Heskett]

On Tuesday 30 December 2003 01:45, Omkhar Arasaratnam wrote:
>On Tue, Dec 30, 2003 at 01:12:00AM -0500, Gene Heskett wrote:
>> On Monday 29 December 2003 14:57, Omkhar Arasaratnam wrote:
>> >Here is another check_region fix, this time for sjcd.c
>> >
>> >--- /usr/src/linux-2.6.0/drivers/cdrom/sjcd.c	2003-12-17
>> > 21:59:05.000000000 -0500 +++ drivers/cdrom/sjcd.c	2003-12-29
>> > 14:52:05.000000000 -0500 @@ -1700,12 +1700,13 @@
>> > 	sprintf(sjcd_disk->disk_name, "sjcd");
>> > 	sprintf(sjcd_disk->devfs_name, "sjcd");
>> >
>> >-	if (check_region(sjcd_base, 4)) {
>> >+	if (!request_region(sjcd_base, 4,"sjcd")) {
>> > 		printk
>> > 		    ("SJCD: Init failed, I/O port (%X) is already in use\n",
>> > 		     sjcd_base);
>> > 		goto out2;
>> > 	}
>> >+	release_region(sjcd_base,4);
>> >
>> > 	/*
>> > 	 * Check for card. Since we are booting now, we can't use
>> > standard
>>
>> I've got two of those check_region() warnings in advansys.c.
>>
>> Would it be appropriate to do a similar fix to it?
>
>Believe it or not I was actually working on advant.c as well. That's
> a big file. I was going to leave it till the AM to post after doing
> a final sanity check (it's almost 2am local time :) 

Humm, 2:26am here...

>I believe this
> _should_ work - perhaps you can advise if line 5390 (after applying
> my patch) will fail because of a duplicate request_region()...
> Either way here is my patch:

I'll give it a try sometime tomorrow, many thanks!  But tonight I'm 
running out of eyeballs.

-- 
Cheers, Gene
AMD K6-III@500mhz 320M
Athlon1600XP@1400mhz  512M
99.22% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attornies please note, additions to this message
by Gene Heskett are:
Copyright 2003 by Maurice Eugene Heskett, all rights reserved.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/