Re: [PATCH] fix make kernel rpm bug

[Zhu, Yi]

On Thu, 25 Dec 2003, Jeff Garzik wrote:

> hmmm, I don't think $(ARCH) makes the rpm --target strings in all
> cases..

>From rpm man page --target PLATFORM will interpret PLATFORM as
arch-vendor-os and set %_target, %_target_cpu, %_target_os accordingly.
In this case only arch is set, so vendor and os will remain as default.

If you still think it is too implicit, how about change as below? In case
you want set RPM_VENDOR_OS to something like "-unknown-linux".


@@ -258,6 +258,7 @@
 AWK            = awk
 RPM            := $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo
rpmbuild; \
                        else echo rpm; fi)
+RPM_VENDOR_OS  :=
 GENKSYMS       = scripts/genksyms/genksyms
 DEPMOD         = /sbin/depmod
 KALLSYMS       = scripts/kallsyms
@@ -872,7 +873,7 @@
        $(CONFIG_SHELL) $(srctree)/scripts/mkversion >
$(objtree)/.tmp_version;\
        mv -f $(objtree)/.tmp_version $(objtree)/.version;

-       $(RPM) -ta ../$(KERNELPATH).tar.gz
+       $(RPM) --target $(ARCH)$(RPM_VENDOR_OS) -ta ../$(KERNELPATH).tar.gz
        rm ../$(KERNELPATH).tar.gz

 # Brief documentation of the typical targets used


>         Jeff

-yi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/