Re: [PATCH][2.4] change two annoying messages from framebuffer drivers

[Michael Hunold]

Hello Marcelo,

On 18.12.2003 20:05, Marcelo Tosatti schrieb:
> On Mon, 15 Dec 2003, Geert Uytterhoeven wrote:
>
>
> > On Fri, 12 Dec 2003, Michael Hunold wrote:
> >
> > > Two framebuffer drivers (clgenfb.c and hgafb.c), however, use KERN_ERR
> > > to say that their particular card has *not* been found which is very
> > > annoying.
> > >
> > > Especially the clgenfb.c driver simply says on bootup:
> > > >  Couldn't find PCI device
> > > which can really confuse newbie users.
> > >
> > > The appended patch replaces two KERN_ERR with KERN_INFO and additionally
> > > makes the clgen.c message more descriptive.
> > >
> > > Please apply, thanks!
> >
> > Patch looks OK to me, except that I would print `clgenfb' instead of `clgen'.
>
>
> That looks sane.
>
> Can you change it Michael?

Attached is an updated patch -- sorry for the long delay.

I'll create a separate patch for 2.6 and sent it to Linus/Andrew.

CU
Michael.
diff -ur xx-linux-2.4.22/drivers/video/clgenfb.c xx-linux-2.4.22.p/drivers/video/clgenfb.c
--- xx-linux-2.4.22/drivers/video/clgenfb.c	2003-06-13 16:51:37.000000000 +0200
+++ xx-linux-2.4.22.p/drivers/video/clgenfb.c	2003-12-12 13:48:34.000000000 +0100
@@ -2547,7 +2547,7 @@
 
 	pdev = clgen_pci_dev_get (btype);
 	if (!pdev) {
-		printk (KERN_ERR " Couldn't find PCI device\n");
+		printk (KERN_INFO "clgenfb: couldn't find Cirrus Logic PCI device\n");
 		DPRINTK ("EXIT, returning 1\n");
 		return 1;
 	}
diff -ur xx-linux-2.4.22/drivers/video/hgafb.c xx-linux-2.4.22.p/drivers/video/hgafb.c
--- xx-linux-2.4.22/drivers/video/hgafb.c	2001-11-12 18:46:25.000000000 +0100
+++ xx-linux-2.4.22.p/drivers/video/hgafb.c	2003-12-12 13:47:01.000000000 +0100
@@ -704,7 +704,7 @@
 int __init hgafb_init(void)
 {
 	if (! hga_card_detect()) {
-		printk(KERN_ERR "hgafb: HGA card not detected.\n");
+		printk(KERN_INFO "hgafb: HGA card not detected.\n");
 		return -EINVAL;
 	}