Re: 2.6.0 Ooops while accessing ejected floppy

[Andrew Morton]

Wiktor Wodecki <wodecki@xxxxxx> wrote:
>
> I forgot to unmount my floppy before ejecting it. No problem here (it is
>  my fault after all) but the kernel gave me an Ooops.
>  Nothing bad really happend, and I could continue work. However, I
>  thought to give a note here.
> 
>  Dec 21 14:50:38 kakerlak kernel: floppy0: disk absent or changed during
>  operation
>  Dec 21 14:50:38 kakerlak kernel: end_request: I/O error, dev fd0, sector
>  7
>  Dec 21 14:50:38 kakerlak kernel: lost page write due to I/O error on fd0 
>  Dec 21 14:50:38 kakerlak kernel: buffer layer error at fs/buffer.c:2827

It's a warning, not an oops.  The below should shut it up.




From: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>

Suppress a buffer_error() warning which occurs when a page which previously
had an I/O error gets its buffers stripped.



 fs/buffer.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/buffer.c~buffer_error-suppression fs/buffer.c
--- 25/fs/buffer.c~buffer_error-suppression	2003-12-21 22:11:33.000000000 -0800
+++ 25-akpm/fs/buffer.c	2003-12-21 22:11:33.000000000 -0800
@@ -2820,7 +2820,7 @@ drop_buffers(struct page *page, struct b
 		bh = bh->b_this_page;
 	} while (bh != head);
 
-	if (!was_uptodate && PageUptodate(page))
+	if (!was_uptodate && PageUptodate(page) && !PageError(page))
 		buffer_error();
 
 	do {

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/