Re: [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo

From: Mike Fedyk
Date: Thu Dec 18 2003 - 14:23:56 EST


On Thu, Dec 18, 2003 at 04:40:12PM +0100, Ronny V. Vindenes wrote:
> Mike Fedyk <mfedyk@xxxxxxxxxxxxx> writes:
> > + K(nr_inactive_dirty_pages()) + K(nr_inactive_dirty_pages())
> ^^^^^
> Shouldn't that be nr_inactive_clean_pages() ? now it's 2*dirty + laundry
>

Yes, good catch. Thanks

> > + + K(nr_inactive_laundry_pages()),

How's this?

--- proc_misc.c.orig 2003-12-16 17:03:45.000000000 -0800
+++ proc_misc.c 2003-12-16 17:04:28.000000000 -0800
@@ -189,6 +189,7 @@
"Active: %8u kB\n"
"ActiveAnon: %8u kB\n"
"ActiveCache: %8u kB\n"
+ "Inactive: %8u kB\n"
"Inact_dirty: %8u kB\n"
"Inact_laundry:%8u kB\n"
"Inact_clean: %8u kB\n"
@@ -208,6 +209,8 @@
K(nr_active_anon_pages()) + K(nr_active_cache_pages()),
K(nr_active_anon_pages()),
K(nr_active_cache_pages()),
+ K(nr_inactive_dirty_pages()) + K(nr_inactive_laundry_pages())
+ + K(nr_inactive_clean_pages()),
K(nr_inactive_dirty_pages()),
K(nr_inactive_laundry_pages()),
K(nr_inactive_clean_pages()),
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/