Re: HT apparently not detected properly on 2.4.23

From: William Lee Irwin III
Date: Wed Dec 03 2003 - 19:47:05 EST


On Wed, Dec 03, 2003 at 06:41:36PM -0500, Ethan Weinstein wrote:
> Ok, setting CONFIG_NR_CPUS=8 does indeed solve the HT issue, looks like
> it was the numbering scheme:

Something like this might do the trick. NR_CPUS is already checked
indirectly via max_cpus.


-- wli


===== arch/i386/kernel/smpboot.c 1.17 vs edited =====
--- 1.17/arch/i386/kernel/smpboot.c Mon Nov 3 05:48:33 2003
+++ edited/arch/i386/kernel/smpboot.c Wed Dec 3 16:45:27 2003
@@ -1106,7 +1106,7 @@
*/
Dprintk("CPU present map: %lx\n", phys_cpu_present_map);

- for (bit = 0; bit < NR_CPUS; bit++) {
+ for (bit = 0; bit < BITS_PER_LONG; bit++) {
apicid = cpu_present_to_apicid(bit);

/* don't try to boot BAD_APICID */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/