Re: AS spin lock bugs

[Jens Axboe]

On Thu, Nov 13 2003, Jens Axboe wrote:
> @@ -959,12 +960,12 @@
>  	if (!aic)
>  		return;
>  
> -	spin_lock(&aic->lock);
> +	spin_lock_irqsave(&aic->lock, flags);
>  	if (arq->is_sync == REQ_SYNC) {
>  		set_bit(AS_TASK_IORUNNING, &aic->state);
>  		aic->last_end_request = jiffies;
>  	}
> -	spin_unlock(&aic->lock);
> +	spin_unlock_irqrestore(&aic->lock, flags);
>  
>  	put_io_context(arq->io_context);
>  }

BTW, this looks bogus. Why do you need any locking there?

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/