Re: [PATCH?] psmouse-base.c

[arief_mulya]

Dmitry Torokhov wrote:

> On Tuesday 11 November 2003 01:54 am, arief_mulya wrote:
>  
>
> > Dmitry Torokhov wrote:
> >    
>
>  
>
> > > Unfortunately I do not suspend my laptop so I did not run it, just
> > > made sure it compiles. Arief? could you give this patch a try?
> > >      
> > I have tested it before.
> > My first attempts looked quite just like that.
> >
> > It didn't work quite nicely.
> > Especially with gpm, after resume, you cannot do Tap-to-Click behaviour
> > with that patch. You can still move it, use left and right button, but
> > no tap-to-click. I don't know why. That's why, finally, I use
> > serio_rescan().
> >
> > I haven't tested it with X, though, as I use gpm as a repeater, I
> > thought this was unnecessary.
> >
> > But I have try Andrew's tree. And it works flawlessly with the patch
> > (case PM_RESUME: serio_reconnect()). I think I'm going to stick with mm
> > tree, and dump my vanilla kernel.
> >
> > One more think, I also sets "psmouse_resetafter" to 1 at the
> > declaration. Without that, I get too many ugly message saying
> > "Synaptics lost sync at 1 byte..." or something like that. As it is a
> > module parameter, but on menuconfig synaptics does not available as
> > module, so I set it directly on the source. I don't know if I can set
> > it on boot time, can it?
> >
> >    
>
> Ok, I somewhat confused as the sequence in psmouse_pm_callback is pretty
> much the same as in rescan/reconnect. Wait...
>
>  
This is what  I thought, too.
Why did it work with serio_rescan() or serio_reconnect() but not with 
the one above?

But on second thought, I didn't know how the kernel works, not then. Not 
now. So when it works for me, my lazy brain, said. That's enough.  ;-)

> Does suspend/resume work at all if you don't set psmouse_resetafter to 1??
>  
Nope. At least, I didn't wait that long. (I hate seeing lots of "lost 
sync" messages in my console forever, so I always reboot. And in X, you 
just get un-moveable mouse.)

> The reason I am asking is that we have alot of different PM interfaces and
> this one is marked as deprecated. If it is not called during resume it would
> leave the touchpad in relative mode while kernel expects absolute and spews 
> "lost sync" messages... Until Synaptics decides that it's time to reset 
> after X bad packets. Does it make any sense?
>
>  
Personally, I don't think it makes any sense.
If something is broken. Why do I need to see lots of funny messages 
(which I didn't even know what it means) if then it could be fixed. Or 
is it has something to do with other serio devices?

> Btw, Synaptics is intergated into psmouse module so you don't really need
> to edit the source to set resetafter parameter. Either pass 
> "psmouse_resetafter=X" to the kernel on boot if psmouse compiled in or
> pass it to modprobe.
>
>  
I thought so, too.
But how do you pass to modprobe something that does not available as 
Module in menuconfig?

Best Regards.
--
arief_mulya
Peace is Beautiful.

> Dmitry
>
>  


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/