Re: EFAULT reading /dev/mem... - broken x86info

From: Manfred Spraul
Date: Mon Nov 10 2003 - 11:52:03 EST


Dave Jones wrote:

I don't really have much insight into the behind the scenes going on's of
DEBUG_PAGEALLOC, so I don't know if your suggestion has merit or not.
Maybe Manfred can shed some insight?

DEBUG_PAGEALLOC is not the only user of change_page_attr: gart also removes it's pages from the linear mapping.
I think x86info should accept the -EFAULT as an indication that the targeted page is in use for other purpose, and definitively doesn't contain a mptable. The other option would be to change both DEBUG_PAGEALLOC and the AGP gart driver

This does seem to be a regression IMO
(Though I am somewhat biased as this breaks my app 8-)

It breaks either your app or your AGP driver - what's simpler to fix? I'm biased, because if you update the AGP driver, then I must figure out how to fix DEBUG_PAGEALLOC 8-)

--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/