Re: [PATCH] cfq-prio #2

[Nick Piggin]

Jens Axboe wrote:

> Hi,

Hi Jens

> @@ -1553,6 +1559,10 @@
> 	struct io_context *ioc = get_io_context(gfp_mask);
>
> 	spin_lock_irq(q->queue_lock);
> +
> +	if (!elv_may_queue(q, rw))
> +		goto out_lock;
> +
> 	if (rl->count[rw]+1 >= q->nr_requests) {
> 		/*
> 		 * The queue will fill after this allocation, so set it as
> @@ -1566,15 +1576,12 @@
> 		}
> 	}
>
> -	if (blk_queue_full(q, rw)
> -			&& !ioc_batching(ioc) && !elv_may_queue(q, rw)) {

I know I hijacked elv_may_queue from you... any chance we could seperate
these so our schedulers can live in peace? ;)

Maybe my version should be called elv_force_queue?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/