Re: [PATCH] Fix find busiest queue 2.6.0-test9

From: Ingo Molnar
Date: Mon Nov 10 2003 - 02:51:03 EST



On Sun, 9 Nov 2003, Davide Libenzi wrote:

> Maybe something like:
>
> * We fend off statistical fluctuations in runqueue lengths by
> * saving the runqueue length (as seen by the balancing CPU) during the
> * previous load-balancing operation and using the smaller one the current
> * and saved lengths.

yep, agreed - patch for 2.6.1 attached. (I also fixed a typo in the
original comment and reformatted the lines) Anything else?

Ingo

--- kernel/sched.c.orig
+++ kernel/sched.c
@@ -1061,10 +1061,11 @@
* the lock held.
*
* We fend off statistical fluctuations in runqueue lengths by
- * saving the runqueue length during the previous load-balancing
- * operation and using the smaller one the current and saved lengths.
- * If a runqueue is long enough for a longer amount of time then
- * we recognize it and pull tasks from it.
+ * saving the runqueue length (as seen by the balancing CPU) during
+ * the previous load-balancing operation and using the smaller one
+ * of the current and saved lengths. If a runqueue is long enough
+ * for a longer amount of time then we recognize it and pull tasks
+ * from it.
*
* The 'current runqueue length' is a statistical maximum variable,
* for that one we take the longer one - to avoid fluctuations in
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/