Re: [PATCH?] psmouse-base.c

From: Dmitry Torokhov
Date: Mon Nov 10 2003 - 01:52:59 EST


On Sunday 09 November 2003 11:12 pm, Andrew Morton wrote:
> arief_mulya <arief_m_utama@xxxxxxxxxxxxxxx> wrote:
> > static int psmouse_pm_callback(struct pm_dev *dev, pm_request_t
> > request, void *data)
> > {
> > struct psmouse *psmouse = dev->data;
> > struct serio_dev *ser_dev = psmouse->serio->dev;
> >
> >
> > switch (request) {
> > case PM_RESUME:
> > psmouse->state = PSMOUSE_IGNORE;
> > serio_rescan(psmouse->serio);
> > default:
> > return 0;
> > }
> > }
>
> What does the driver do without this change? ie: what problem is this
> fixing?
>
> Why is it calling serio_rescan() rather than serio_reconnect()?
>

serio_reconnect() is only in your tree (-mm), it has not been pushed to
Linus yet... Unfortunately using rescan can cause input devices be shifted
if some program has them open while suspending.

Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/